Dev dbg mitchell branch #100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is surrounded by same type of quote (opensearch-project#696) Signed-off-by: mitchellg <mitchellg@bitquilltech.com> Co-authored-by: Andrew Carbonetto <andrewc@AndrewsMBP2022.local>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
… outside of main OS sql project (opensearch-project#704) Signed-off-by: mitchellg <mitchellg@bitquilltech.com>
* Add support for highlight to parser and AstExpressionBuilder
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add unit test for highlight in AstExpressionBuilder
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add unit test for highlight in AstBuilderTest
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Support highlight as an Unresolved expression.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Represent highlight as UnresolvedExpression.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Support highlight in Analyzer.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Treat highlight as a proper function in AST
In particular, highlightField is an expression now.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add support for highlight in Analyzer
HighlightFunction is converted to LogicalHighlight logical plan.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add a simple IT test for highlight.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Register highlight function in the BuiltInFunctionRepository
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Partial support for highlight in physical plan.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Add HighlightOperator.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Highlight alpha complete.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
* Initial implementation to upporting highlight('*')
Signed-off-by: forestmvey <forestv@bitquilltech.com>
* Add support for multiple highlight calls in select statement.
Signed-off-by: forestmvey <forestv@bitquilltech.com>
* Removed OpenSearchLogicalIndexScan highlightFields and dependencies. Improved test coverage and fixing checkstyle errors.
Signed-off-by: forestmvey <forestv@bitquilltech.com>
* Added HighlightExpressionTest
Signed-off-by: forestmvey <forestv@bitquilltech.com>
* Added javadocs, minor PR revisions, and fixed jacoco errors by improving coverage for OpenSearchIndexScan
Signed-off-by: forestmvey <forestv@bitquilltech.com>
* Code cleanup, adding parsing failure tests, and adding tests for highlight acceptance as a string literal as well as qualified name.
Signed-off-by: forestmvey <forestv@bitquilltech.com>
* Removing HighlightOperator functionality and unnecessary visitHighlight call in PhysicalPlanNodeVisitor..
Signed-off-by: forestmvey <forestv@bitquilltech.com>
* Adding highlight function to functions.rst and removing unecessary function call in OpenSearchIndexScan.
Signed-off-by: forestmvey <forestv@bitquilltech.com>
* Change highlight fields returned format to array list. Changed highlight all and wildcard to unsupported to open up output formatting changes for multiple returned highlight fields. Change tests for updated coverage and disable highlight all and wildcard tests.
Signed-off-by: forestmvey <forestv@bitquilltech.com>
* Fix bug where invalid schema name was being used for returned highlight fields
Signed-off-by: forestmvey <forestv@bitquilltech.com>
* Fix failing integration tests due to schema changes for highlight expression type.
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
…te` into new branch. Co-authored-by: Mitchell Gale <mitchellg@bitquilltech.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Author
|
Used for testing of DCO. Never needed. Real PR for this PR test is #103. |
andy-k-improving
pushed a commit
that referenced
this pull request
Nov 16, 2024
Add XYPoint Field Mapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.